Skip to content

MAINT force NumPy version for building scikit-learn for CPython 3.10 in Windows #24742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 25, 2022
Merged

MAINT force NumPy version for building scikit-learn for CPython 3.10 in Windows #24742

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ed838eb
MAINT force numpy version for Windows and Python 3.10
glemaitre Oct 24, 2022
1af464d
[cd build] trigger wheels
glemaitre Oct 24, 2022
d08949e
[cd build] different order since not() does not exist
glemaitre Oct 24, 2022
60f5cb0
specify the correct set of parametrs
glemaitre Oct 24, 2022
0765187
[cd build] trigger wheel build
glemaitre Oct 24, 2022
e562ece
Add link to scipy
ogrisel Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,12 @@ requires = [
# wheels on PyPI
#
# see: https://github.com/scipy/oldest-supported-numpy/blob/main/setup.cfg
"oldest-supported-numpy",
"oldest-supported-numpy; python_version!='3.10' or platform_system!='Windows' or platform_python_implementation=='PyPy'",
# For CPython 3.10 under Windows, SciPy requires NumPy 1.22.3 while the
# oldest supported NumPy is defined as 1.21.6. We therefore need to force
# it for this specific configuration. For details, see
# https://github.com/scipy/scipy/blob/c58b608c83d30800aceee6a4dab5c3464cb1de7d/pyproject.toml#L38-L41
"numpy==1.22.3; python_version=='3.10' and platform_system=='Windows' and platform_python_implementation != 'PyPy'",

"scipy>=1.3.2",
]
Expand Down