Skip to content

MAINT bump up CI dependencies #24803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 4, 2022
Merged

MAINT bump up CI dependencies #24803

merged 16 commits into from
Nov 4, 2022

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Nov 1, 2022

Apparently this hasn't been done in a while. Let's see if the CI is happy.

@ogrisel
Copy link
Member Author

ogrisel commented Nov 1, 2022 •
edited
Loading

There are still 2 build failing because of a deprecation warning in pytest-xdist itself:

+ eval 'python -m pytest --showlocals --durations=20 --junitxml=test-data.xml --cov-config='\''/home/vsts/work/1/s/.coveragerc'\'' --cov sklearn --cov-report= -Werror::DeprecationWarning -Werror::FutureWarning -Werror::numpy.VisibleDeprecationWarning -Wignore:tostring:DeprecationWarning -Wignore:The\ distutils:DeprecationWarning -Wignore:distutils\ Version\ classes\ are\ deprecated:DeprecationWarning -Werror::pytest.PytestUnraisableExceptionWarning -n2 --pyargs sklearn'
++ python -m pytest --showlocals --durations=20 --junitxml=test-data.xml --cov-config=/home/vsts/work/1/s/.coveragerc --cov sklearn --cov-report= -Werror::DeprecationWarning -Werror::FutureWarning -Werror::numpy.VisibleDeprecationWarning -Wignore:tostring:DeprecationWarning '-Wignore:The distutils:DeprecationWarning' '-Wignore:distutils Version classes are deprecated:DeprecationWarning' -Werror::pytest.PytestUnraisableExceptionWarning -n2 --pyargs sklearn
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/usr/share/miniconda/envs/testvenv/lib/python3.9/site-packages/_pytest/main.py", line 266, in wrap_session
INTERNALERROR>     config._do_configure()
INTERNALERROR>   File "/usr/share/miniconda/envs/testvenv/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1037, in _do_configure
INTERNALERROR>     self.hook.pytest_configure.call_historic(kwargs=dict(config=self))
INTERNALERROR>   File "/usr/share/miniconda/envs/testvenv/lib/python3.9/site-packages/pluggy/_hooks.py", line 277, in call_historic
INTERNALERROR>     res = self._hookexec(self.name, self.get_hookimpls(), kwargs, False)
INTERNALERROR>   File "/usr/share/miniconda/envs/testvenv/lib/python3.9/site-packages/pluggy/_manager.py", line 80, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>   File "/usr/share/miniconda/envs/testvenv/lib/python3.9/site-packages/pluggy/_callers.py", line 60, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/usr/share/miniconda/envs/testvenv/lib/python3.9/site-packages/pluggy/_result.py", line 60, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/usr/share/miniconda/envs/testvenv/lib/python3.9/site-packages/pluggy/_callers.py", line 39, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/usr/share/miniconda/envs/testvenv/lib/python3.9/site-packages/xdist/plugin.py", line 214, in pytest_configure
INTERNALERROR>     config.issue_config_time_warning(warning, 2)
INTERNALERROR>   File "/usr/share/miniconda/envs/testvenv/lib/python3.9/site-packages/_pytest/config/__init__.py", line 1394, in issue_config_time_warning
INTERNALERROR>     warnings.warn(warning, stacklevel=stacklevel)
INTERNALERROR> DeprecationWarning: The --rsyncdir command line argument and rsyncdirs config variable are deprecated.
INTERNALERROR> The rsync feature will be removed in pytest-xdist 4.0.
##[error]Bash exited with code '3'.

however we do not use the --rsyncdir commandline option, so I am not sure what to do about this.

@ogrisel
Copy link
Member Author

ogrisel commented Nov 1, 2022

I will implement pytest-dev/pytest-xdist#825 (comment).

@ogrisel
Copy link
Member Author

ogrisel commented Nov 1, 2022

The filterwarnings directive is ignored. Maybe I need to quote it in one way or another?

@glemaitre
Copy link
Member

glemaitre commented Nov 2, 2022 •
edited
Loading

Maybe we can just pin pytest to have it working and await to be fixed upstream.
We can upgrade the other dependencies.

@ogrisel
Copy link
Member Author

ogrisel commented Nov 3, 2022

I will pin pytest-xdist.

@ogrisel
Copy link
Member Author

ogrisel commented Nov 3, 2022

Hum I don't understand how test_fit_gibbs could work it seems like a very brittle test... Maybe I am missing something.

glemaitre
glemaitre reviewed Nov 3, 2022
View reviewed changes
sklearn/neural_network/tests/test_rbm.py
@@ -101,6 +101,8 @@ def test_sample_hiddens():


def test_fit_gibbs():
# XXX: this test is very seed-dependent! It probably needs to be rewritten.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will comeback on it when dealing with the global_seed.

@ogrisel
Copy link
Member Author

ogrisel commented Nov 3, 2022

I forgot to re-trigger [scipy-dev] in the last commit push. Let me wait for the current build to complete before re-pushing with the extra builds.

ogrisel
ogrisel commented Nov 3, 2022
View reviewed changes
jjerphan
jjerphan approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CI runs are green.

@ogrisel ogrisel merged commit 63f92d4 into scikit-learn:main Nov 4, 2022
@ogrisel ogrisel deleted the bump-up-ci-deps-2022-11-01 branch November 4, 2022 10:59
@ogrisel
Copy link
Member Author

ogrisel commented Nov 4, 2022

Yeah, it's green, even for pypy!

@ogrisel ogrisel mentioned this pull request Nov 4, 2022
Closed
andportnoy pushed a commit to andportnoy/scikit-learn that referenced this pull request Nov 5, 2022
@ogrisel @andportnoy
MAINT bump up CI dependencies (scikit-learn#24803)
aa80731 
[scipy-dev] [pypy]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
Build / CI No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogrisel @glemaitre @jjerphan