FIX Calls super().init_subclass in _SetOutputMixin #24863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Nov 8, 2022
| return X | ||
|
|
||
| est = BothMixinEstimator() | ||
| assert est.custom_parameter == 123 |
There was a problem hiding this comment.
we should also check that the estimator has the set_output method, to make sure both are executed.
adrinjalali
approved these changes
Nov 8, 2022
|
LGTM Thanks @adrinjalali and @thomasjpfan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #24854
What does this implement/fix? Explain your changes.
This PR calls
init_subclassin_SetOutputMixin, which allows other mixins to be defined with their own parameters.