Skip to content

FIX Make sure that set_output is keyword only everywhere #24890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2022
Merged

FIX Make sure that set_output is keyword only everywhere #24890

merged 2 commits into from
Nov 11, 2022

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Saw this while reviewing #24889

What does this implement/fix? Explain your changes.

This PR makes the meta-estimators' set_output method use keyword only arguments, which is consistent with the _SetOutputMixin.

CC @glemaitre @ogrisel

@thomasjpfan thomasjpfan added No Changelog Needed Quick Review For PRs that are quick to review labels Nov 10, 2022
@thomasjpfan thomasjpfan added this to the 1.2 milestone Nov 10, 2022
ogrisel
ogrisel approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I will update my PR accordingly.

@adrinjalali adrinjalali merged commit e947074 into scikit-learn:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
module:compose module:pipeline No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @ogrisel @adrinjalali