Skip to content

MAINT Remove -Wcpp warnings when compiling sklearn.utils.murmurhash #24958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 24, 2022
Merged

MAINT Remove -Wcpp warnings when compiling sklearn.utils.murmurhash #24958

merged 4 commits into from
Nov 24, 2022

Conversation

Vincent-Maladiere
Copy link
Contributor

Reference Issues/PRs

Towards #24875

What does this implement/fix? Explain your changes.

  • Replace cnp.ndarray by memoryviews
  • Return np.ndarray through .base for outputs
  • Replace the check isinstance(key, cnp.ndarray) with _is_arraylike

Any other comments?

cc @jjerphan

jjerphan
jjerphan approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a green CI.

jeremiedbb
jeremiedbb reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Vincent-Maladiere

jeremiedbb
jeremiedbb approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a nitpick: we tend to prefer np.asarray(x) instead of x.base

@jeremiedbb jeremiedbb merged commit f9b16f2 into scikit-learn:main Nov 24, 2022
@jeremiedbb
Copy link
Member

Thanks @Vincent-Maladiere

@jjerphan jjerphan mentioned this pull request Nov 30, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjerphan jjerphan jjerphan approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
cython module:cluster module:utils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vincent-Maladiere @jeremiedbb @jjerphan