Skip to content

MAINT Remove -Wcpp warnings when compiling sklearn.linear_model._sag_fast #24975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 29, 2022
Merged

MAINT Remove -Wcpp warnings when compiling sklearn.linear_model._sag_fast #24975

merged 6 commits into from
Nov 29, 2022

Conversation

OmarManzoor
Copy link
Contributor

@OmarManzoor OmarManzoor commented Nov 18, 2022 •
edited
Loading

Reference Issues/PRs

Towards #24875

What does this implement/fix? Explain your changes.

  • Fixed -Wcpp warnings due to the usage of deprecated cnp.ndarray. when compiling sklearn.linear_model._sag_fast.
  • Replaced the usages of cnp.ndarray with memory views.
  • Used the addresses to the memory views to refer to the corresponding pointers that are in use.
  • Did some black formatting to make it easier to read the code.

Any other comments?

  • Is it possible to remove the _multinomial_grad_loss_all_samples function because the only usage I found for this method is in a test.

jjerphan
jjerphan approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once again, thank you, @OmarManzoor.

thomasjpfan
thomasjpfan approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @OmarManzoor ! LGTM

@thomasjpfan thomasjpfan merged commit 808c32d into scikit-learn:main Nov 29, 2022
@OmarManzoor OmarManzoor deleted the cython_sag_fast branch November 29, 2022 18:24
@jjerphan jjerphan mentioned this pull request Nov 30, 2022
Closed
22 tasks
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@OmarManzoor @jjerphan
MAINT Remove -Wcpp warnings when compiling sklearn.linear_model._sag_…
97065a9 
…fast (scikit-learn#24975)
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@OmarManzoor @jjerphan
MAINT Remove -Wcpp warnings when compiling sklearn.linear_model._sag_…
b3f2dc7 
…fast (scikit-learn#24975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@jjerphan jjerphan jjerphan approved these changes

Assignees
No one assigned
Labels
cython module:linear_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OmarManzoor @thomasjpfan @jjerphan