-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC Update "Parallelism, resource management, and configuration" section #24997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Update "Parallelism, resource management, and configuration" section #24997
Conversation
Co-authored-by: Tim Head <betatim@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping this doc up to date. Here is my feedback:
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…SE_DIST_CHUNK_SIZE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @jjerphan!
You are welcome! @betatim, is everything clear to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging, thanks! |
Reference Issues/PRs
Relates to #22587.
What does this implement/fix? Explain your changes.
Update this section of the documentation regarding latest changes, new back-ends introductions and
threadpoolctl
.Any other comments?
I am thinking that it would be nice to have a list of implementations that are relying on OpenMP for parallelisation so that user which specific workflow can set appropriate values for environement variables.
Also, it would be nice to have a "label" in the documentation to know if interfaces have their implementations parallelized using
joblib
orOpenMP
.Note that interfaces backed by #22587 probably should have a comment in their docstrings to indicate cases where
n_jobs
do not apply anymore.What do you think, @jeremiedbb, @thomasjpfan and @ogrisel?