Skip to content

CI Correctly define configuration for flake8 #25017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

thomasjpfan
Copy link
Member

This PR fixes the linting issue in CI in flake8.

According to the flake8 docs, we were incorrect placing comments inline.

@thomasjpfan thomasjpfan changed the title CI Correctly define configuration for flake8 CI: Correctly define configuration for flake8 Nov 23, 2022
@thomasjpfan thomasjpfan added the Quick Review For PRs that are quick to review label Nov 23, 2022
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrinjalali adrinjalali changed the title CI: Correctly define configuration for flake8 CI Correctly define configuration for flake8 Nov 24, 2022
@adrinjalali adrinjalali merged commit 845b19f into scikit-learn:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build / CI Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants