MAINT Remove -Wcpp warnings when compiling sklearn.ensemble._gradient_boosting #25033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
glemaitre
reviewed
Dec 1, 2022
|
@jjerphan Could you kindly have a look at this PR? |
|
@glemaitre , @jjerphan Is this PR capable of being merged? |
|
Thanks for the heads-up, @OmarManzoor. |
Thank you for the quick merge 😃 |
|
We often multitask between PRs and issues so it's easy to loose track of what is mergeable. See #25069 for more context. |
Totally understandable. Thank you for your consideration. |
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 3, 2023
…_boosting (scikit-learn#25033) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
…_boosting (scikit-learn#25033) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
…_boosting (scikit-learn#25033) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24875
What does this implement/fix? Explain your changes.
Any other comments?