DOC Use notebook style in plot_gpr_on_structured_data.py #25132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We still have the following warning: It might be worth decreasing the lower bound as suggested. |
For info, we tried doing so with a lower bound as low as 1e-24 and it still raises a warning. Setting the lower bound to exactly zero still raises a |
|
OK. Let's revisit the notebook where we would need to dig into the meaning of the kernel used and the associated hyperparameter. Removing the matplotlib warning and notebook-style structure is already a great improvement. |
|
Thanks @ArturoAmorQ |
Vincent-Maladiere
pushed a commit
to Vincent-Maladiere/scikit-learn
that referenced
this pull request
Dec 14, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 21, 2022
glemaitre
pushed a commit
that referenced
this pull request
Dec 21, 2022
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 3, 2023
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Related to #22406.
What does this implement/fix? Explain your changes.
The Gaussian processes on discrete data structures example is raising a Matplotlib
UserWarning. This PR fixes it while implementing notebook style.Any other comments?
The example still raises a
ConvergenceWarning. I am open to suggestions on how to fix it without making the code too charged.