FIX Convert boolean pd.Series to boolean ndarrays #25147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For types that are not pandas extension dtypes, we should ask numpy to tell us the best dtype, so that we preserve the behaviour of boolean Series being converted to boolean arrays.
thomasjpfan
reviewed
Dec 9, 2022
thomasjpfan
reviewed
Dec 9, 2022
thomasjpfan
reviewed
Dec 9, 2022
thomasjpfan
reviewed
Dec 9, 2022
|
Comments done and what's new added |
thomasjpfan
reviewed
Dec 9, 2022
thomasjpfan
approved these changes
Dec 9, 2022
ogrisel
approved these changes
Dec 12, 2022
Vincent-Maladiere
pushed a commit
to Vincent-Maladiere/scikit-learn
that referenced
this pull request
Dec 14, 2022
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 3, 2023
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 20, 2023
jjerphan
pushed a commit
to jjerphan/scikit-learn
that referenced
this pull request
Jan 23, 2023
adrinjalali
pushed a commit
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For types that are not pandas extension dtypes, we should ask numpy to tell us the best dtype, so that we preserve the behaviour of boolean Series being converted to boolean arrays.
The story is a bit confused by categorical dtypes :-/ So while this fixes the regression and doesn't break any existing tests in
test_validation.py, it feels like we are adding a layer on top of several layers of "fixes" and exceptions in the conversion logic. Ideas welcome.Closes #25145