Skip to content

Fix bug identified in #1817, comment 17340049 #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2013

Conversation

rmcgibbo
Copy link
Contributor

Here's the bug report:

#1817 (comment)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling b98b71b on rmcgibbo:hmmfix into a2580d6 on scikit-learn:master.

@jaquesgrobler
Copy link
Member

+1 for merge

@ogrisel
Copy link
Member

ogrisel commented Oct 21, 2013

Looks good as well to me but I am not familiar with the HMM code. Maybe @kmike or @SnippyHolloW can have a look.

If I understand correctly, observations with a sequence length of 1 are just ignored when updating the stats to estimate the transition probabilities?

@syhw
Copy link
Contributor

syhw commented Oct 21, 2013

The bypass seems fine to me. I previously did the check on my side (before calling fit()).

Maybe add a comment on the line of the "if > 1" to say there are no transitions to update with with 1 observation sequences? +1 for merge otherwise.

@ogrisel
Copy link
Member

ogrisel commented Oct 21, 2013

+1 for adding an explicit inline comment.

@kmike
Copy link
Contributor

kmike commented Oct 21, 2013

I was using end-of-sentence markers and haven't had this problem because of that. The PR looks good.

@rmcgibbo
Copy link
Contributor Author

comment applied.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling fc3fcb8 on rmcgibbo:hmmfix into a2580d6 on scikit-learn:master.

@ogrisel
Copy link
Member

ogrisel commented Oct 25, 2013

Thanks! merging.

ogrisel added a commit that referenced this pull request Oct 25, 2013
Fix bug identified in #1817, comment 17340049
@ogrisel ogrisel merged commit 55efb67 into scikit-learn:master Oct 25, 2013
@rmcgibbo rmcgibbo deleted the hmmfix branch May 2, 2014 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants