Skip to content

ENH Raise NotFittedError in get_feature_names_out for AdditiveChi2Sampler #25291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2023
Merged

ENH Raise NotFittedError in get_feature_names_out for AdditiveChi2Sampler #25291

merged 2 commits into from
Jan 6, 2023

Conversation

rprkh
Copy link
Contributor

@rprkh rprkh commented Jan 4, 2023

Reference Issues/PRs

Towards #24916

What does this implement/fix? Explain your changes.

Included check_is_fitted in get_feature_names_out for AdditiveChi2Sampler

Any other comments?

Test passes pytest -vsl sklearn/tests/test_common.py -k estimators_get_feature_names_out_error

@jpangas jpangas mentioned this pull request Jan 4, 2023
Closed
36 tasks
@jpangas
Copy link
Contributor

jpangas commented Jan 4, 2023

@rprkh , I was advised by @adrinjalali to include all the estimators in one change-log entry. I have created the change-log entry in #25294, so you may make edits (include the class you've worked on, plus your name) after PR #25294 has been merged.

@glemaitre
Copy link
Member

I would be in favor of merging #25294 as proposed by @jpangas and then add the entry in the same changelog.

@jpangas
Copy link
Contributor

jpangas commented Jan 5, 2023

@rprkh , Feel free to now include your estimator's class name in the same change log entry. The PR has been successfully merged. 🙂

@rprkh rprkh force-pushed the enh_not_fitted_additivechi2sampler branch from 7884f95 to cdc2739 Compare January 6, 2023 04:09
@rprkh
Copy link
Contributor Author

rprkh commented Jan 6, 2023

Included the changelog entry.

@glemaitre glemaitre merged commit 37bd51d into scikit-learn:main Jan 6, 2023
@glemaitre
Copy link
Member

Thanks @rprkh

@rprkh rprkh deleted the enh_not_fitted_additivechi2sampler branch January 6, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rprkh @jpangas @glemaitre @adrinjalali