Skip to content

DOC document how to generate a valid CIRCLE_CI_TOKEN #25338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

DOC document how to generate a valid CIRCLE_CI_TOKEN #25338

merged 1 commit into from
Jan 9, 2023

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Jan 9, 2023 •
edited
Loading

We started getting a permission denied message when running build_tools/github/trigger_hosting.sh on all new builds:

curl --request POST --url https://circleci.com/api/v2/project/gh/scikit-learn/scikit-learn/pipeline --header 'Circle-Token: ***' --header 'content-type: application/json' --header 'x-attribution-actor-id: github_actions' --header 'x-attribution-login: github_actions' --data '{"branch":"main","parameters":{"GITHUB_RUN_URL":"https://nightly.link/scikit-learn/scikit-learn/actions/runs/3872020543"}}'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
{
100   159  100    37  100   122    323   1067 --:--:-- --:--:-- --:--:--  1407
  "message" : "Permission denied"
}

see for instance: https://github.com/scikit-learn/scikit-learn/actions/runs/3872313863/jobs/6601020506

I updated the github actions secret with a new personal circle ci token generated using my account. This PR adds a comment to the config file to make this more explicit.

jjerphan
jjerphan approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this explicit, @ogrisel.

@lesteve lesteve enabled auto-merge (squash) January 9, 2023 10:38
lesteve
lesteve approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I enabled auto-merge

@lesteve lesteve merged commit bc00bdc into scikit-learn:main Jan 9, 2023
@ogrisel ogrisel deleted the maint-doc-secrets.CIRCLE_CI_TOKEN branch January 9, 2023 10:59
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 9, 2023
@jjerphan @ogrisel
CI Handle Circle CI REST API response
9e7fd01 
Follow-up of scikit-learn#25338.

Circle CI REST API return HTTP response with 202 status code
even when the POST requests fail.

This proposes adding some handling so that errors are reported on
GitHub.

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@jjerphan jjerphan mentioned this pull request Jan 9, 2023
Closed
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@ogrisel @jjerphan
DOC document how to generate a valid CIRCLE_CI_TOKEN (scikit-learn#25338
7c4b514 
)
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@ogrisel @jjerphan
DOC document how to generate a valid CIRCLE_CI_TOKEN (scikit-learn#25338
5c2451a 
)
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 23, 2023
@ogrisel @jjerphan
DOC document how to generate a valid CIRCLE_CI_TOKEN (scikit-learn#25338
4e7e724 
)
adrinjalali pushed a commit that referenced this pull request Jan 24, 2023
@ogrisel @adrinjalali
DOC document how to generate a valid CIRCLE_CI_TOKEN (#25338)
448c399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve approved these changes

@jjerphan jjerphan jjerphan approved these changes

@alfaro96 alfaro96 Awaiting requested review from alfaro96

@thomasjpfan thomasjpfan Awaiting requested review from thomasjpfan

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogrisel @lesteve @jjerphan