Skip to content

CI Migrate Linux ARM job to CirrusCI #25366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 12, 2023

Conversation

thomasjpfan
Copy link
Member

This PR moves the Linux ARM job from CircleCI to CirrusCI. This Linux ARM job is exactly the same as the CircleCI job and runs on every PR.

@thomasjpfan
Copy link
Member Author

The Cirrus CI output is available as one of the checks in this PR. It is named "linux_aarch64_test".

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ogrisel
Copy link
Member

ogrisel commented Jan 12, 2023

Actually, I think the github status check requirement needs to be updated not to wait for circle ci anymore:

image

@thomasjpfan
Copy link
Member Author

I removed the CircleCI test from the branch protection rules. We'll need to add the new CirrusCI one once this PR is merged.

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan merged commit dc7ef61 into scikit-learn:main Jan 12, 2023
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
* CI Migrate Linux ARM job to CirrusCI

* CI Completely remove linux-arm reference from circleci

* CI Add noop job so circleci works

* DOC Update comment in circleci config

* Apply suggestions from code review

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
* CI Migrate Linux ARM job to CirrusCI

* CI Completely remove linux-arm reference from circleci

* CI Add noop job so circleci works

* DOC Update comment in circleci config

* Apply suggestions from code review

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 23, 2023
* CI Migrate Linux ARM job to CirrusCI

* CI Completely remove linux-arm reference from circleci

* CI Add noop job so circleci works

* DOC Update comment in circleci config

* Apply suggestions from code review

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
adrinjalali pushed a commit that referenced this pull request Jan 24, 2023
* CI Migrate Linux ARM job to CirrusCI

* CI Completely remove linux-arm reference from circleci

* CI Add noop job so circleci works

* DOC Update comment in circleci config

* Apply suggestions from code review

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants