Skip to content

ENH Raise NotFittedError in get_feature_names_out for VotingClassifier and Voting Regressor #25398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rprkh
Copy link
Contributor

@rprkh rprkh commented Jan 14, 2023

Reference Issues/PRs

Towards #24916

What does this implement/fix? Explain your changes.

Included check_is_fitted in get_feature_names_out for Voting Classifier and Voting Regressor

Any other comments?

Test passes pytest -vsl sklearn/tests/test_common.py -k estimators_get_feature_names_out_error

@rprkh
Copy link
Contributor Author

rprkh commented Jan 14, 2023

Closing this and including the required changes in #25324 so its easier to review

@rprkh rprkh deleted the enh_voting_classifier_regressor branch January 17, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant