Skip to content

CI Update conda-lock from 1.2.1 to 1.3.0 #25404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Jan 16, 2023

Reference Issues/PRs

Allows solving dead-lock encountered in #25342.

What does this implement/fix? Explain your changes.

conda-lock 1.3.0 was released on December 9th 2022, see: https://github.com/conda-incubator/conda-lock/releases/tag/v1.3.0

As indicated here:

# XXX: Pin conda-lock to the latest released version (needs manual update
# from time to time)
"conda-lock": ("1.2.1", "maintenance"),

This PR updates conda-lock from 1.2.1 to 1.3.0 and regenerates lock files using:

python build_tools/update_environments_and_lock_files.py

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CIs turns green

@lesteve
Copy link
Member

lesteve commented Jan 16, 2023

Allows solving dead-lock encountered in #25342.

The deadlock has actually been fixed in #25361 🤔 (moving sphinx out of the pip section into the conda one)

@lesteve
Copy link
Member

lesteve commented Jan 16, 2023

The CI is green and I think it is fine to move to the latest conda-lock version, let's merge this one.

@lesteve lesteve merged commit 71ca925 into scikit-learn:main Jan 16, 2023
@jjerphan jjerphan deleted the ci/update-conda-lock-to-1.3.0 branch January 16, 2023 10:22
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants