Skip to content

DOC Update changelog before the 1.2.1 release #25436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 20, 2023
Merged

DOC Update changelog before the 1.2.1 release #25436

merged 8 commits into from
Jan 20, 2023

Conversation

jjerphan
Copy link
Member

@ogrisel and I are preparing the 1.2.1 release.
We think those PRs have to be part of it and have changed the release note accordingly.

We also want to have #25114 #25131 #25129 and #25147 be part of this release, but those do not feature in the changelog (mostly because those are maintenance changes).

What do you think?

@thomasjpfan
Copy link
Member

Here are my thoughts:

@jjerphan
Copy link
Member Author

I agree with what @thomasjpfan suggests. Do you, @ogrisel?

@ogrisel
Copy link
Member

ogrisel commented Jan 20, 2023

Alright!

@jjerphan
Copy link
Member Author

Based on @thomasjpfan's comment, the change-log does not need to be modified. I guess all the issues back-ported from 1.3 to 1.2.X are possible and that the PR is thus mergeable if the CI is green. WDYT?

@jjerphan jjerphan mentioned this pull request Jan 20, 2023
Merged
12 tasks
@jjerphan
Copy link
Member Author

FYI I have opened #25442 for releasing 1.2.1, and I am waiting for the current PR (i.e. #25436) to be merged before pursuing the release process.

jeremiedbb
jeremiedbb reviewed Jan 20, 2023
View reviewed changes
thomasjpfan
thomasjpfan approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan merged commit 4162ade into scikit-learn:main Jan 20, 2023
@jjerphan jjerphan deleted the doc/retarget-prs-for-1.2.1 branch January 20, 2023 16:44
@jjerphan
Copy link
Member Author

Thanks, @thomasjpfan!

jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
@jjerphan
DOC Update changelog before the 1.2.1 release (scikit-learn#25436)
d6d991d
jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 23, 2023
@jjerphan
DOC Update changelog before the 1.2.1 release (scikit-learn#25436)
2d69986
adrinjalali pushed a commit that referenced this pull request Jan 24, 2023
@jjerphan @adrinjalali
DOC Update changelog before the 1.2.1 release (#25436)
1d6d023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@jeremiedbb jeremiedbb jeremiedbb left review comments

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjerphan @thomasjpfan @ogrisel @jeremiedbb