-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
TST Actually compare feature importances when computed in parallel #25445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is an failure on ARM which does not seem related to this PR ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! LGTM
As for the random ARM failure, I opened #25446 to stabilize the tests in |
Actually from Olivier's comment in another issue, The code is here. |
What does this implement/fix? Explain your changes.
Looks like the test was meant to compare feature importances with
n_jobs=1
andn_jobs=2
but we were actually not calling.fit
...Unless I am very tired and I am missing something subtle of course ...