Skip to content

MAINT Parameters validation for sklearn.datasets.fetch_kddcup99 #25463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 7, 2023
+14 −0
Merged

MAINT Parameters validation for sklearn.datasets.fetch_kddcup99 #25463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3fcb4c2
MAINT Parameters validation for sklearn.datasets.fetch_kddcup99
pm155 Jan 23, 2023
dc4e148
Merge branch 'main' into main
pm155 Jan 24, 2023
227cb9c
MAINT Parameters validation for sklearn.datasets.fetch_kddcup99
pm155 Jan 24, 2023
9726f52
Merge branch 'main' into main
pm155 Jan 24, 2023
9610895
MAINT black compliance
glemaitre Feb 2, 2023
29ae5d0
Merge branch 'main' into main
glemaitre Feb 2, 2023
8e60c65
Merge branch 'main' into main
jeremiedbb Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions sklearn/datasets/_kddcup99.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from . import get_data_home
from ._base import RemoteFileMetadata
from ._base import load_descr
from ..utils._param_validation import StrOptions, validate_params
from ..utils import Bunch
from ..utils import check_random_state
from ..utils import shuffle as shuffle_method
Expand All @@ -46,6 +47,18 @@
logger = logging.getLogger(__name__)


@validate_params(
{
"subset": [StrOptions({"SA", "SF", "http", "smtp"}), None],
"data_home": [str, None],
"shuffle": ["boolean"],
"random_state": ["random_state"],
"percent10": ["boolean"],
"download_if_missing": ["boolean"],
"return_X_y": ["boolean"],
"as_frame": ["boolean"],
}
)
def fetch_kddcup99(
*,
subset=None,
Expand Down
1 change: 1 addition & 0 deletions sklearn/tests/test_public_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ def _check_function_param_validation(
"sklearn.covariance.empirical_covariance",
"sklearn.covariance.shrunk_covariance",
"sklearn.datasets.fetch_california_housing",
"sklearn.datasets.fetch_kddcup99",
"sklearn.datasets.make_classification",
"sklearn.datasets.make_sparse_coded_signal",
"sklearn.decomposition.sparse_encode",
Expand Down