Skip to content

DOC Update news footer for 1.2.1 (#25472) #25473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2023
Merged

DOC Update news footer for 1.2.1 (#25472) #25473

merged 2 commits into from
Jan 24, 2023

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Jan 24, 2023 •
edited
Loading

This PR is to backport #25472 into 1.2.X.

Even after merging #25466, I think the previous doc building workflow should still work.

@thomasjpfan
Copy link
Member Author

With #25466, merged, the GitHub Action to trigger CircleCI has been removed. This means this PR needs to cherry pick #25466 onto 1.2.X as well.

glemaitre
glemaitre approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rendering is fine so I assume that it should work.

@thomasjpfan thomasjpfan merged commit ff1023f into scikit-learn:1.2.X Jan 24, 2023
@thomasjpfan thomasjpfan deleted the 1.2.1_footnote branch January 24, 2023 20:24
@thomasjpfan
Copy link
Member Author

It all worked. The website has been updated with the footnote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Documentation No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasjpfan @glemaitre @jjerphan @lesteve