Skip to content

MNT Remove allowed type for check_parameters_default_constructible #25479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jan 25, 2023

It seems like allowing joblib.Memory as default argument is not used anywhere. Let's see if the CI agrees.

@betatim
Copy link
Member

betatim commented Jan 26, 2023

Why do you want to remove it? Just because nothing in scikit-learn uses it now, doesn't mean people from the future can't/shouldn't use it. Or, if there is a reason to not use it I think it would be good to record it here so those people from the future have an easier time figuring out why :D

@lesteve
Copy link
Member Author

lesteve commented Jan 26, 2023

I think this is more an accident of history that Memory was allowed as a default argument value but you are right that it could in principle be used in third-party estimators and so that this change would potentially cause them not to pass check_estimator ... all in all I think this is the kind of thing which is not worth spending too much time over.

I'll leave the PR open for a few days for other opinions but I am fine closing it.

For further reference, the result of a code archaeology session:

@lesteve
Copy link
Member Author

lesteve commented Jan 27, 2023

Closing in favour of #25498

@lesteve lesteve closed this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants