ENH allows to overwrite read_csv parameter in fetch_openml #25488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Feb 7, 2023
| the default options. Internally, we used the default parameters of | ||
| :func:`pandas.read_csv` except for the following parameters: | ||
|
|
||
| - `header`: set to `None` |
There was a problem hiding this comment.
Should this be in fetch_openml as part of the public API?
| dtype=dtypes, | ||
| skipinitialspace=True, # skip spaces after delimiter to follow ARFF specs | ||
| ) | ||
| frame = pd.read_csv(gzip_file, **read_csv_kwargs) |
There was a problem hiding this comment.
Currently, if there is an exception while reading the data, one would need to enter a debugger to find out where the file is and what the read_csv_kwargs are. I think it would be helpful reraise an exception that outputs the read_csv_kwargs and gzip_file to help with debugging the issue.
|
I will close this one. Let's keep in mind that it exists if we really need more flexibility and tweak the parameter in the future. |
|
OK, so opening back this one. It seems that we will need it if we want to manage ourself some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to overwrite the parameter passed to
read_csvwhen reading a dataframe.It is not intended to be used widely but it could be worth it when things go sideways.