Skip to content

CI Allow cirrus arm tests to run with cd build commit tag #25514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2023
Merged

CI Allow cirrus arm tests to run with cd build commit tag #25514

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b4f233
CI Allow cirrus arm build to run with tag
thomasjpfan Jan 30, 2023
ec3773e
CI [cd build cirrus]
thomasjpfan Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cirrus.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ def main(ctx):
return []

if "[cd build]" in commit_msg or "[cd build cirrus]" in commit_msg:
return fs.read(arm_wheel_yaml)
return fs.read(arm_wheel_yaml) + fs.read(arm_tests_yaml)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, we previously only build the wheel and install it but did not test it. Regarding the testing, we only test one of the python versions?

Copy link
Member Author

@thomasjpfan thomasjpfan Jan 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously tagging with [cd build] would only trigger the build the wheels, which also tests on all supported Python versions, but the normal Linux ARM tests did not run. The arm_tests_yaml is a Linux ARM test environment similar to the Azure CI jobs and nothing to do with wheel building. With this PR, the Linux ARM test will run all the time, independent of any tag.

Concretely, looking at the Cirrus job for this PR, the jobs tagged with CIBW_BUILD are the wheel builds and linux_aarch64_test is the Linux ARM test.


return fs.read(arm_tests_yaml)