DOC Clearer and more illustrative description for f_beta_score #25548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearer and more illustrative description about the `beta` parameter
thomasjpfan
reviewed
Feb 7, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
pnucci
commented
Feb 8, 2023
There was a problem hiding this comment.
@thomasjpfan just one thing: with that suggestion, we lost the word "importance". Now we are saying "ratio of recall to precision". I still believe we should say something like
"ratio of recall importance to precision importance"
or
"importance ratio of recall to precision"
after all, beta is not a ratio of the metrics, just a ratio of their importance/weights
what are your thoughts?
|
I was trying to think of a way not to say importance twice. In any case, I am okay with your original suggestion:
|
thomasjpfan
reviewed
Feb 8, 2023
|
Hi @thomasjpfan, are you ok with the last proposal? are we good to approve it? |
thomasjpfan
reviewed
Apr 28, 2023
thomasjpfan
approved these changes
May 16, 2023
ArturoAmorQ
approved these changes
May 22, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…t-learn#25548) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearer and more illustrative description about the
betaparameter. The original text mentions "weight of recall", without being clear that it's a ratio. Two intuitive examples are added, instead of discussing the asymptotic behaviour ofbeta.Reference Issues/PRs
What does this implement/fix? Explain your changes.
Simple improvement in the documentation for f_beta_score, to make it more accurate and pragmatic.
Any other comments?