Add special case handling for default engine #25549
Merged
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can give a prefix to this PR. I think What do you think, Tim? 🙂 |
|
I think MAINT is more for non functional code changes (release, style reformatting or another code reorg that does not change the user-facing behavior of the code base). Here is more like a FIX to not raise an exception in a context where it should not have been raised in the first place. There is also ENH for code behavior improvement for functional changes that improve the behavior for something that was not really considered as a bug but more like a limitation of the previous version of the code. |
ogrisel
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem that if you did not configure a special engine provider, then you could not keep using the estimator. The logic needed an exception for the default engine.
This PR targets the "plugin engine" feature branch.
@fcharras @jjerphan @ogrisel