-
-
Notifications
You must be signed in to change notification settings - Fork 26k
ENH Adds infrequent categories support to OrdinalEncoder #25677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
betatim
merged 29 commits into
scikit-learn:main
from
thomasjpfan:oridinal_encoder_max_categories
Mar 29, 2023
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
a021438
ENH Adds infrequent categories support to OrdinalEncoder
thomasjpfan d07eec5
DOC Adds PR number
thomasjpfan 4753302
FIX Adds parameter validation
thomasjpfan 2a0ee6f
DOC Adds example with unknown_value and encoded_missing_value
thomasjpfan 84f7a9f
DOC Explain max_categories
thomasjpfan 8d113d8
CLN Better variable name
thomasjpfan 95f333e
CLN Better variable name
thomasjpfan 2f602bc
FIX Fixes issue with edge case
thomasjpfan da45840
CLN Better variable names
thomasjpfan 0ae6180
CLN Better parameter name
thomasjpfan 0ff894f
CLN Simplify code paths
thomasjpfan 75da3cb
TST Adds test for corner case
thomasjpfan 13f40cf
Apply suggestions from code review
thomasjpfan 38b0e6c
DOC Better wording for user guide
thomasjpfan 410eec3
DOC Adds comment
thomasjpfan bc2ddc0
Merge remote-tracking branch 'upstream/main' into oridinal_encoder_ma…
thomasjpfan a1685e4
DOC Address comments
thomasjpfan 399b0ff
Merge remote-tracking branch 'upstream/main' into oridinal_encoder_ma…
thomasjpfan 19fa3f4
FIX Fixes merge issues
thomasjpfan 7cf3dc4
DOC Fix docstrings
thomasjpfan 4aa0754
DOC Formatting
thomasjpfan 8743af8
Merge remote-tracking branch 'upstream/main' into oridinal_encoder_ma…
thomasjpfan 6e1e732
DOC Reword
thomasjpfan fa0c7ae
Merge remote-tracking branch 'upstream/main' into oridinal_encoder_ma…
thomasjpfan 43ce0c9
FIX Includes required import
thomasjpfan 4bdb513
Merge remote-tracking branch 'upstream/main' into oridinal_encoder_ma…
thomasjpfan 93b8679
FIX Fixes validation framework test
thomasjpfan 1e8f139
Apply suggestions from code review
thomasjpfan d300fe9
TST Increase coverage
thomasjpfan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.