Skip to content

MAINT Added Parameter Validation for metrics.make_scorer() #25760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 6, 2023
Merged

MAINT Added Parameter Validation for metrics.make_scorer() #25760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
19ffbd8
Added parameter validation for mkae_scorer and added test
ZeeshanLone Mar 4, 2023
1a6609d
move line is test_public_function for alphabetical ordering
ZeeshanLone Mar 4, 2023
b072552
Merge branch 'scikit-learn:main' into make_scorer
ZeeshanLone Mar 6, 2023
cc18d04
flake8 test passes on sklearn/metrics/_scorer.py after reformating wi…
ZeeshanLone Mar 6, 2023
54a4ead
Removed unintentional change caused by black to getitem function
ZeeshanLone Mar 6, 2023
5b2a833
revert unrelated
jeremiedbb Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sklearn/metrics/_scorer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,14 @@ def _check_multimetric_scoring(estimator, scoring):
return scorers


@validate_params(
{
"score_func": [callable],
"greater_is_better": ["boolean"],
"needs_proba": ["boolean"],
"needs_threshold": ["boolean"],
}
)
def make_scorer(
score_func,
*,
Expand Down
1 change: 1 addition & 0 deletions sklearn/tests/test_public_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ def _check_function_param_validation(
"sklearn.metrics.jaccard_score",
"sklearn.metrics.label_ranking_loss",
"sklearn.metrics.log_loss",
"sklearn.metrics.make_scorer",
"sklearn.metrics.matthews_corrcoef",
"sklearn.metrics.max_error",
"sklearn.metrics.mean_absolute_error",
Expand Down