Skip to content

DOC Allows section links to be visible when linked #25783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Mar 8, 2023

This PR allows anchor links to appear directly under the navbar. For example, this link to the cluster example navigates to shows the following. With this PR, the "Clustering" header is actually visible.

main

Screenshot 2023-03-08 at 1 24 06 PM

This PR

Screenshot 2023-03-08 at 1 24 59 PM

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I just have a naive question.

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've always found it annoying

Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan enabled auto-merge (squash) March 10, 2023 14:41
@jjerphan jjerphan disabled auto-merge March 13, 2023 09:05
@jjerphan jjerphan merged commit e305e80 into scikit-learn:main Mar 13, 2023
Veghit pushed a commit to Veghit/scikit-learn that referenced this pull request Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants