Skip to content

MAINT parameter validation for sklearn.datasets.load_svmlight_files #25811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

genvalen
Copy link
Contributor

Reference Issues/PRs

Toward #24862

What does this implement/fix? Explain your changes.

Summary of changes:

  • Add parameter validation for sklearn.datasets.load_svmlight_files.

Any other comments?

genvalen and others added 9 commits March 8, 2023 19:58
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
…nto validate_params_datasets_load_svmlight_files
Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @genvalen

@jeremiedbb jeremiedbb merged commit 18aab04 into scikit-learn:main Mar 13, 2023
Veghit pushed a commit to Veghit/scikit-learn that referenced this pull request Apr 15, 2023
…cikit-learn#25811)

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants