MAINT Parameters validation for metrics.recall_score #25816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is and can be the source of significant slowdowns for some function. This is why I opened #25815 to be able to avoid these nested validations. |
Thanks for your answer, I will have a look at #25815. |
This was referenced Mar 13, 2023
Veghit
pushed a commit
to Veghit/scikit-learn
that referenced
this pull request
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24862
What does this implement/fix? Explain your changes.
This PR implements parameter validation for
metrics.recall_scoreAny other comments?
I followed the same pattern as
metrics.precision_score, however I wonder if implementing parameter validation for functions deriving frommetrics.precision_recall_fscore_supportis/was really necessary:metrics.f1_scoremetrics.fbeta_scoremetrics.precision_scoremetrics.recall_scoreIndeed these function all eventually call
metrics.precision_recall_fscore_support, whose parameters are validated. Isn't it redundant to validate parameters for these functions as well?