CLN Cleaned TreeUnionFind in _hdbscan/_tree.pyx
#25827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
approved these changes
Mar 13, 2023
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
thomasjpfan
reviewed
Mar 13, 2023
sklearn/cluster/_hdbscan/_tree.pyx
Outdated
| cdef union_(self, cnp.intp_t x, cnp.intp_t y): | ||
| cdef cnp.ndarray[cnp.intp_t, ndim=2] data_arr | ||
| data_arr = np.zeros((size, 2), dtype=np.intp) | ||
| data_arr.T[0] = np.arange(size) |
There was a problem hiding this comment.
Seems a little waste to create a new array just for setting the values of another array. What is the performance like for doing it manually for large size?
for i in range(size):
data_arr[i, 0] = i
Micky774
added a commit
to Micky774/scikit-learn
that referenced
this pull request
May 16, 2023
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #24686
What does this implement/fix? Explain your changes.
Any other comments?