TST random seed global /svm/tests/test_svm.py #25891
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremiedbb
reviewed
Mar 21, 2023
There was a problem hiding this comment.
Thanks for the PR @Veghit. There are many tests in this file that could use the global_random_seed since they currently use a fixed random_state
sklearn/svm/tests/test_svm.py
Outdated
Comment on lines
1076
to
1077
| X = np.random.RandomState(global_random_seed).randn(10, 3) | ||
| y = np.random.RandomState(global_random_seed + 1).randn(10) |
There was a problem hiding this comment.
Suggested change
| X = np.random.RandomState(global_random_seed).randn(10, 3) | |
| y = np.random.RandomState(global_random_seed + 1).randn(10) | |
| rng = np.random.RandomState(global_random_seed) | |
| X = rng.randn(10, 3) | |
| y = rng.randn(10) |
…wer thresholds and other fixes.
…wer thresholds and other fixes.
… TST_random_seed_global_svm # Conflicts: # sklearn/svm/tests/test_svm.py
…cikit-learn#25811) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
…t-learn#26166) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
…cikit-learn#26165) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
…butions (scikit-learn#26161) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: jeremie du boisberranger <jeremiedbb@yahoo.fr>
…wer thresholds and other fixes.
…wer thresholds and other fixes.
… TST_random_seed_global_svm # Conflicts: # sklearn/svm/tests/test_svm.py
|
@jeremiedbb fixed the rest of the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Towards #22827
What does this implement/fix? Explain your changes.
using random global seed for sklearn/svm/tests/test_svm.py to enable better testing.
Any other comments?
tests pass without logic changes. Decided to use global seed also for the test_svc_nonfinite_params test as it does not take much time and has some potential issues even though it is a simple test.