MAINT Parameter validation for d2_absolute_error_score #25998
Conversation
|
@adrinjalali would appreciate your review |
| @@ -1499,7 +1499,17 @@ def d2_pinball_score( | |||
|
|
|||
| return np.average(output_scores, weights=avg_weights) | |||
|
|
|||
|
|
|||
| @validate_params( | |||
There was a problem hiding this comment.
This should solve the issue with the linter.
| @validate_params( | |
| @validate_params( |
There was a problem hiding this comment.
This should solve the linting problem (running black would also solve this issue).
There was a problem hiding this comment.
yes absolutely! doing it right now.
I apologize for the stupid question(First time contributing), simply add it and push it on the same branch after doing the pytest?
There was a problem hiding this comment.
You have to make the change on your local branch and execute pytest locally for this test_public_functions.py file. If it passes, then you can safely commit and push on your remote. This will synchronize this pull-request and our continuous integration will run your changes on all supported platforms.
There was a problem hiding this comment.
That's exactly what I did this afternoon.
|
fixed my mistakes, I hope I did it correctly this time (sorry for the mess, first time) |
|
I think that you forgot to push the changes into your remote.
It is not a problem. Reviews and requested changes are part of the contribution experience :) |
|
Closing in favor of #26066 |
Reference Issues/PRs
What does this implement/fix? Explain your changes.
adding automatic validation to the d2_absolute_error_score metric from #24862
Any other comments?