Skip to content

TST add global_random_seed fixture to sklearn/datasets/tests/test_rcv1.py #26043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2023
Merged

TST add global_random_seed fixture to sklearn/datasets/tests/test_rcv1.py #26043

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5c7d7d
test-rcv1 [all random seeds]
marenwestermann Apr 1, 2023
63e6faf
fix linting [all random seeds]
marenwestermann Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sklearn/datasets/tests/test_rcv1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from sklearn.utils._testing import assert_array_equal


def test_fetch_rcv1(fetch_rcv1_fxt):
def test_fetch_rcv1(fetch_rcv1_fxt, global_random_seed):
data1 = fetch_rcv1_fxt(shuffle=False)
X1, Y1 = data1.data, data1.target
cat_list, s1 = data1.target_names.tolist(), data1.sample_id
Expand Down Expand Up @@ -42,7 +42,9 @@ def test_fetch_rcv1(fetch_rcv1_fxt):
assert num == Y1[:, j].data.size

# test shuffling and subset
data2 = fetch_rcv1_fxt(shuffle=True, subset="train", random_state=77)
data2 = fetch_rcv1_fxt(
shuffle=True, subset="train", random_state=global_random_seed
)
X2, Y2 = data2.data, data2.target
s2 = data2.sample_id

Expand Down