Skip to content

MAINT Parameters validation for sklearn.metrics.pairwise.cosine_distances #26046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2023
Merged

MAINT Parameters validation for sklearn.metrics.pairwise.cosine_distances #26046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a6fe384
MAINT Parameters validation for sklearn.metrics.pairwise.cosine_dista…
Charlie-XIAO Apr 1, 2023
10c261f
no need to check, validation done in cosine_similarity
Charlie-XIAO Apr 1, 2023
c241c6f
Merge branch 'main' into param-val-cosine_distances
jeremiedbb Apr 3, 2023
2e3a4c6
Revert "no need to check, validation done in cosine_similarity"
Charlie-XIAO Apr 3, 2023
efe1bbd
Merge branch 'param-val-cosine_distances' of https://github.com/Charl…
Charlie-XIAO Apr 3, 2023
d4a0758
Merge branch 'main' into param-val-cosine_distances
jeremiedbb Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sklearn/metrics/pairwise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,6 +980,12 @@ def manhattan_distances(X, Y=None, *, sum_over_features="deprecated"):
return D.reshape((-1, X.shape[1]))


@validate_params(
{
"X": ["array-like", "sparse matrix"],
"Y": ["array-like", "sparse matrix", None],
}
)
def cosine_distances(X, Y=None):
"""Compute cosine distance between samples in X and Y.

Expand Down
1 change: 1 addition & 0 deletions sklearn/tests/test_public_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ def _check_function_param_validation(
"sklearn.metrics.mutual_info_score",
"sklearn.metrics.ndcg_score",
"sklearn.metrics.pairwise.additive_chi2_kernel",
"sklearn.metrics.pairwise.cosine_distances",
"sklearn.metrics.pairwise.cosine_similarity",
"sklearn.metrics.pairwise.haversine_distances",
"sklearn.metrics.pairwise.laplacian_kernel",
Expand Down