Skip to content

Changing float64 to uint8 in OneHotEncoder #26088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Changing float64 to uint8 in OneHotEncoder #26088

wants to merge 1 commit into from

Conversation

BabaYaga1221
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Change float64 dtype to uint8 in sklearn\preprocessing\_encoder.py (as intended in #26063);

Any other comments?

@glemaitre
Copy link
Member

This is not that easy. If we decide to do this change then we need to make some deprecation.
Please refer to https://scikit-learn.org/dev/developers/contributing.html#deprecation to know how to change the default and deprecate it.

@adrinjalali
Copy link
Member

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module:preprocessing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BabaYaga1221 @glemaitre @adrinjalali