-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MAINT Parameters validation for graph.single_source_shortest_path_length #26091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT Parameters validation for graph.single_source_shortest_path_length #26091
Conversation
ff82d03
to
16b2171
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @ChVeen. Here are some comments
16b2171
to
448c7b1
Compare
@jeremiedbb, thanks for all the hints, I solved the issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @ChVeen
036fc09
to
b358b7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Running the CI to make sure the error was just transient.
I am going to try updating the minimal version of |
OK, this is interesting. It seems that the |
I found out that the files
were not updated to the new pytest version. Now, the INTERNALERROR seems to be back... 🤷 |
It is what I intended to do here: #26184 |
…test_path_length The new pytest version is needed as committed to main by PR scikit-learn#26184
Signed-off-by: Christian Veenhuis <124370897+ChVeen@users.noreply.github.com>
@glemaitre Finally it works. It seems that pytest did not like the
by
|
…gth (scikit-learn#26091) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
…gth (scikit-learn#26091) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Reference Issues/PRs
Towards #24862
What does this implement/fix? Explain your changes.
This PR implements automatic parameters validation for sklearn.utils.graph.single_source_shortest_path_length
Any other comments?