Skip to content

MAINT Parameters validation for sklearn.metrics.mean_poisson_deviance #26117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

MAINT Parameters validation for sklearn.metrics.mean_poisson_deviance #26117

wants to merge 2 commits into from

Conversation

pooja-subramaniam
Copy link
Contributor

Reference Issues/PRs

Towards #24862

What does this implement/fix? Explain your changes.

Adding validating parameters decorator to metrics.mean_poisson_deviance.

Veghit
Veghit approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@Veghit Veghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Charlie-XIAO
Copy link
Contributor

Charlie-XIAO commented Apr 7, 2023 •
edited
Loading

Hi, I do think this is a duplicate of this previous pr #26104, which has not been reviewed yet

@jeremiedbb jeremiedbb added No Changelog Needed Validation related to input validation labels Apr 7, 2023
@jeremiedbb
Copy link
Member

Thanks for the PR @pooja-subramaniam but there's already a PR for that as @Charlie-XIAO noticed. Closing in favor of the older one.

@jeremiedbb jeremiedbb closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veghit Veghit Veghit approved these changes

Assignees
No one assigned
Labels
module:metrics No Changelog Needed Validation related to input validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pooja-subramaniam @Charlie-XIAO @jeremiedbb @Veghit