MAINT Parameters validation for sklearn.metrics.pairwise.pairwise_distances_argmin_min #26123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aizardar
approved these changes
Apr 7, 2023
glemaitre
reviewed
Apr 14, 2023
sklearn/metrics/pairwise.py
Outdated
| "X": ["array-like", "sparse matrix"], | ||
| "Y": ["array-like", "sparse matrix"], | ||
| "axis": [Options(Integral, {0, 1})], | ||
| "metric": [str, callable], |
There was a problem hiding this comment.
Similarly to #26124, we will need to specify the set of correct strings. I have to check around to see which list should use there.
jeremiedbb
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Fixed the metric constraint. LGTM. Thanks @pooja-subramaniam
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
…tances_argmin_min (scikit-learn#26123) Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…tances_argmin_min (scikit-learn#26123) Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
towards #24862
What does this implement/fix? Explain your changes.
added automatic validation of sklearn.metrics.pairwise.pairwise_distances_argmin_min