Skip to content

MAINT Parameters validation for sklearn.datasets.load_digits #26195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2023
Merged

MAINT Parameters validation for sklearn.datasets.load_digits #26195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e9c939
Validation for load_digits
jiawei-zhang-a Apr 17, 2023
5022aa1
at least 1 class
jeremiedbb Apr 19, 2023
2577f4d
cln
jeremiedbb Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sklearn/datasets/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,14 @@
from os import environ, listdir, makedirs
from os.path import expanduser, isdir, join, splitext
from pathlib import Path
from numbers import Integral

from ..preprocessing import scale
from ..utils import Bunch
from ..utils import check_random_state
from ..utils import check_pandas_support
from ..utils.fixes import _open_binary, _open_text, _read_text, _contents
from ..utils._param_validation import validate_params
from ..utils._param_validation import validate_params, Interval

import numpy as np

Expand Down Expand Up @@ -820,6 +821,13 @@ def load_breast_cancer(*, return_X_y=False, as_frame=False):
)


@validate_params(
{
"n_class": [Interval(Integral, 1, 10, closed="both")],
"return_X_y": ["boolean"],
"as_frame": ["boolean"],
}
)
def load_digits(*, n_class=10, return_X_y=False, as_frame=False):
"""Load and return the digits dataset (classification).

Expand Down
1 change: 1 addition & 0 deletions sklearn/tests/test_public_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ def _check_function_param_validation(
"sklearn.datasets.fetch_species_distributions",
"sklearn.datasets.load_breast_cancer",
"sklearn.datasets.load_diabetes",
"sklearn.datasets.load_digits",
"sklearn.datasets.load_iris",
"sklearn.datasets.load_svmlight_file",
"sklearn.datasets.load_svmlight_files",
Expand Down