Skip to content

DOC example on feature selection using negative tol values #26205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 26, 2023
Merged

DOC example on feature selection using negative tol values #26205

merged 13 commits into from
Jul 26, 2023

Conversation

rprkh
Copy link
Contributor

@rprkh rprkh commented Apr 18, 2023

Reference Issues/PRs

Closes #25525

What does this implement/fix? Explain your changes.

Includes an example that demonstrates feature selection using SequentialFeatureSelector with negative values of tol.

Any other comments?

@rprkh
Copy link
Contributor Author

rprkh commented Apr 18, 2023

Added the changes.

betatim
betatim approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, what do others think?

ArturoAmorQ
ArturoAmorQ reviewed Apr 21, 2023
View reviewed changes
examples/feature_selection/plot_select_from_model_diabetes.py Outdated
@@ -143,3 +143,67 @@
# attribute. The forward SFS is faster than the backward SFS because it only
# needs to perform `n_features_to_select = 2` iterations, while the backward
# SFS needs to perform `n_features - n_features_to_select = 8` iterations.

# %%
# Selecting features using Sequential Feature Selection and negative tolerance values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a quite long title. My suggestion is to remove the title Discussion to keep the text as part of the narrative of the Selecting features with Sequential Feature Selection section. The this whole block can become a subsection called Using negative tolerance values or something similar.

@rprkh
Copy link
Contributor Author

rprkh commented Apr 22, 2023

Added the changes

@ArturoAmorQ ArturoAmorQ mentioned this pull request Apr 24, 2023
Merged
rprkh and others added 2 commits April 24, 2023 22:21
@rprkh @ArturoAmorQ
Update examples/feature_selection/plot_select_from_model_diabetes.py
a55ab82 
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
@rprkh
lint
437f8cc
@rprkh
Copy link
Contributor Author

rprkh commented Apr 24, 2023 •
edited
Loading

In a non-related topic, remember you can accept the changes directly from github. That makes the review process a bit easier :)

Yep, I included the changes using this. Its much better than using the command line :)

ArturoAmorQ
ArturoAmorQ reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may also be a good idea to display the roc_auc_score in each iteration. For this you will have to add a LogisticRegression step at the end of the pipeline.

rprkh and others added 4 commits April 26, 2023 18:54
@rprkh @ArturoAmorQ
Update examples/feature_selection/plot_select_from_model_diabetes.py
dc9c04b 
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
@rprkh @ArturoAmorQ
Update examples/feature_selection/plot_select_from_model_diabetes.py
4e40295 
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
@rprkh
roc auc scores
3d5f4c2
@rprkh
lint
39ecc4c
@rprkh
Copy link
Contributor Author

rprkh commented Apr 26, 2023

Added the ROC AUC scores.

@ArturoAmorQ
Copy link
Member

Added the ROC AUC scores.

Thanks! Now it look really good! Just a final comment on my side, can you please print the roc_auc_score up to the 3rd decimal?

@rprkh
Copy link
Contributor Author

rprkh commented Apr 26, 2023 •
edited
Loading

Updated the ROC AUC scores to 3 decimal places.

ArturoAmorQ
ArturoAmorQ approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rprkh!

@Micky774 Micky774 merged commit b6dd04e into scikit-learn:main Jul 26, 2023
@Micky774
Copy link
Contributor

Two standing approvals, plus it LGTM as well -- went ahead and merged. Thanks @rprkh @betatim, and@ArturoAmorQ for your work!

@rprkh rprkh deleted the doc_example_sfs_neg_tol branch July 27, 2023 04:23
@Micky774 Micky774 mentioned this pull request Jul 27, 2023
Merged
punndcoder28 pushed a commit to punndcoder28/scikit-learn that referenced this pull request Jul 29, 2023
@rprkh @ArturoAmorQ @punndcoder28
DOC example on feature selection using negative tol values (scikit-…
05150c5 
…learn#26205)

Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
@rprkh @ArturoAmorQ @glemaitre
DOC example on feature selection using negative tol values (scikit-…
56a4fde 
…learn#26205)

Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
jeremiedbb pushed a commit that referenced this pull request Sep 20, 2023
@rprkh @ArturoAmorQ @jeremiedbb
DOC example on feature selection using negative tol values (#26205)
6ef2b26 
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@rprkh @ArturoAmorQ @REDVM
DOC example on feature selection using negative tol values (scikit-…
5aa92da 
…learn#26205)

Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim approved these changes

@ArturoAmorQ ArturoAmorQ ArturoAmorQ approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend SequentialFeatureSelector example to demonstrate how to use negative tol
4 participants
@rprkh @ArturoAmorQ @Micky774 @betatim