TST add test_binomial_vs_alternative_formulation #26298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
approved these changes
May 3, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Micky774
approved these changes
May 10, 2023
There was a problem hiding this comment.
LGTM but since I pushed a change since the last time @thomasjpfan reviewed, I'll leave the merger to him to ensure all still looks well
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Meekail Zain <zainmeekail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Makes #26278 smaller
What does this implement/fix? Explain your changes.
It adds a test for the binomial loss function that compares with an alternative formulation. This test is taken from
sklearn.ensemble.test.test_gradient_boosting_loss_functions.py,test_binomial_deviance(which will be removed with #26278).Any other comments?