ENH Add sample_weight parameter to OneHotEncoder's .fit
#26330
+253
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stments to sum(sample_weight)=0 scenario
|
As I had to adapt to the #27381 PR related to the new array API (#26024 for details), this PR got a little bit denser. The failing CI is due to coverage. Anyway, before I continue to work on this PR, I think I need a review otherwise I might invest too much time into some path (maybe I already did that hahah) and have to change it all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26248.
This PR adds
sample_weightparameter toOneHotEncoder.fitfunction and calculate level frequencies usingsample_weightsum instead of counting. Also, this enables the ranking of categories accordingly for the use ofmax_categories.