-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
ENH check_classification_targets
raises a warning when unique classes > 50% of n_samples
#26335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adrinjalali
merged 25 commits into
scikit-learn:main
from
rprkh:enh_check_classification_targets
Apr 30, 2025
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f679bff
raise warning when unique classes > 50% of n_samples
rprkh a4b6675
changelog
rprkh 3513e91
move warning to type_of_target and modify test accordingly
rprkh 384c816
modify changelog for type_of_target
rprkh 0d00435
update test for lint
rprkh 7c69259
reduce failing tests
rprkh bcd08b0
explicitly raise warning to prevent errors
rprkh b731553
fix lint - y
rprkh 8cbe6ac
reduce dependence on lineno and use line instead
rprkh ca39690
lint again
rprkh d36a711
modified tests
rprkh 3988f80
remove import
rprkh 02d820c
Merge branch 'main' into enh_check_classification_targets
rprkh f70e2b5
update tests
rprkh 743bed0
fix merge conflicts in changelog
rprkh 8dcea63
remove extra line
rprkh 7bdda2f
make seperate try/except blocks
rprkh 89af61d
Merge remote-tracking branch 'origin/main' into pr/rprkh/26335-1
glemaitre d85131a
avoid raising if the number of samples is low
glemaitre f7bb57f
revert missing blank line
glemaitre 1881322
Merge remote-tracking branch 'upstream/main' into enh_check_classific…
adrinjalali 6c225f6
No need for raw strings
betatim a3b21a2
review
adrinjalali 8b3ddd7
Merge branch 'enh_check_classification_targets' of github.com:rprkh/s…
adrinjalali 31415d7
Merge remote-tracking branch 'upstream/main' into enh_check_classific…
adrinjalali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
doc/whats_new/upcoming_changes/sklearn.utils/26335.enhancement.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
- |Enhancement| :func:`utils.multiclass.type_of_target` raises a warning when the number | ||
of unique classes is greater than 50% of the number of samples. This warning is raised | ||
only if `y` has more than 20 samples. | ||
By :user:`Rahil Parikh <rprkh>`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.