FIX Update pairwise distance function argument names #26351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
previously approved these changes
May 10, 2023
thomasjpfan
reviewed
May 23, 2023
Comment on lines
492
to
493
| class_membership, | ||
| unique_classes, |
There was a problem hiding this comment.
If I had the chance to rename these, I'll go with:
class_membership->y_labels: Directly connects this parameter withyunique_classes->labels: This is consistent with thelabelskwargs in themetricsmodule
There was a problem hiding this comment.
Great suggestion. I do much prefer those names. @jjerphan I wonder what you think regarding these.
There was a problem hiding this comment.
This indeed looks better (I trust you for coming up with the best, appropriate names).
There was a problem hiding this comment.
Small heads-up, @Micky774. Is there something missing for this PR? :)
Dismissing review due to failure and recent changes
|
@jjerphan @thomasjpfan CI error fixed, new variable names adopted. Pinging for review whenever you have time :) |
thomasjpfan
approved these changes
Jul 25, 2023
jjerphan
approved these changes
Jul 25, 2023
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Updates arguments to conform to the names originally decided in #24076
Any other comments?
cc: @jjerphan @ogrisel