Do I need to make tests for this? If so, do we add separate tests or parametrize current tests with the additional keyword?

Do I need to make tests for this? If so, do we add separate tests or parametrize current tests with the additional keyword?

We would need to make a test to check that the parameter has the desired impact. I think that this is fine to isolate the checks in a new separate test.

#26019 has been merged and I have resolved the merge conflicts. I think there has been no reply for over a week on this PR as well as #26366 and #26368. No hurry but is there any update on this issue @glemaitre?

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: cd9c439. Link to the linter CI: here}

Since #26366 is now merged, maybe this one is also ready for review? ping @glemaitre

ping @Charlie-XIAO are you still interested in working on this? (I think this is the last item before we can close #25929)

Yes sure, I will find some time within these days to resolve the conflicts and make things up-to-date first.

@lucyleeow I've updated :)

Sorry for the delay and thanks for the suggestion @lucyleeow! I've added despine=True to the two basic examples using ROC curve and PR curve:

• https://output.circle-artifacts.com/output/job/f0774eca-1aef-44c6-8fb3-bb74e0ce218d/artifacts/0/doc/auto_examples/model_selection/plot_precision_recall.html
• https://output.circle-artifacts.com/output/job/f0774eca-1aef-44c6-8fb3-bb74e0ce218d/artifacts/0/doc/auto_examples/model_selection/plot_roc.html

CI is strangely failing but I think none of those is related to this PR.

Maybe ping @glemaitre for another review? This is implemented based on your initial design #25929 (comment)

I thought that I reviewed this PR but apparently I did not post my comments.
I'll make another pass tomorrow.