Skip to content

MAINT bump minimum pytest to 7.1.2 #26373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2023
Merged

MAINT bump minimum pytest to 7.1.2 #26373

merged 1 commit into from
May 15, 2023

Conversation

glemaitre
Copy link
Member

Closes #26371
Linked to #25639

It seems that bumping the version to pytest 7.1.2 avoid the internal error bug that we spotted in some PRs (e.g. #25639).

I updated the lock files.

ogrisel
ogrisel approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This bump should mostly impact our CI so +1.

@ogrisel ogrisel merged commit 5782cd7 into scikit-learn:main May 15, 2023
@jeremiedbb jeremiedbb mentioned this pull request May 25, 2023
Closed
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@glemaitre @REDVM
MAINT bump minimum pytest to 7.1.2 (scikit-learn#26373)
5cd2f77
@Charlie-XIAO Charlie-XIAO mentioned this pull request Nov 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glemaitre @ogrisel @adrinjalali