Skip to content

DOC Update daal4py -> scikit-learn-intelex reference #26383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 17, 2023
Merged

DOC Update daal4py -> scikit-learn-intelex reference #26383

merged 5 commits into from
May 17, 2023

Conversation

napetrov
Copy link
Contributor

What does this implement/fix? Explain your changes.

This change replace daal4py mention with relevant scikit-learn-intelex as well as updating links

Also would love to discuss any ongoing issues with package and fact it's being used on top of scikit-learn itself. One of the problems i've heard was defects submission against scikit-learn instead of scikit-learn-intelex

thomasjpfan
thomasjpfan reviewed May 16, 2023
View reviewed changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @napetrov !

@napetrov @thomasjpfan
Apply suggestions from code review
2257649 
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@napetrov
Copy link
Contributor Author

There are doc build related failures. but looks there are problems with access to ubuntu repos

@napetrov napetrov requested a review from thomasjpfan May 16, 2023 15:32
@thomasjpfan thomasjpfan changed the title daal4py -> scikit-learn-intelex reference DOC Update daal4py -> scikit-learn-intelex reference May 16, 2023
@thomasjpfan thomasjpfan added Waiting for Second Reviewer First reviewer is done, need a second one! Quick Review For PRs that are quick to review labels May 16, 2023
ogrisel
ogrisel approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Here are some more fixes / suggested improvements:

@ogrisel
Copy link
Member

ogrisel commented May 16, 2023

Indeed the Circle CI failures are from timed out connections to ubuntu apt repos:

Err:5 http://security.ubuntu.com/ubuntu focal-security InRelease
  Could not connect to security.ubuntu.com:80 (185.125.190.36), connection timed out Could not connect to security.ubuntu.com:80 (91.189.91.39), connection timed out Could not connect to security.ubuntu.com:80 (185.125.190.39), connection timed out
Err:6 http://archive.ubuntu.com/ubuntu focal InRelease

so unrelated to this PR.

@napetrov @ogrisel
Apply suggestions from code review
133fd38 
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@ogrisel ogrisel enabled auto-merge (squash) May 16, 2023 16:09
@adrinjalali adrinjalali disabled auto-merge May 16, 2023 16:49
adrinjalali
adrinjalali requested changes May 16, 2023
View reviewed changes
@napetrov napetrov requested a review from adrinjalali May 16, 2023 17:21
@ogrisel ogrisel enabled auto-merge (squash) May 17, 2023 08:08
@ogrisel
Copy link
Member

ogrisel commented May 17, 2023

Merged!

@jeremiedbb
Copy link
Member

Looks like the "change requested" is blocking the auto merge :)

adrinjalali
adrinjalali requested changes May 17, 2023
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I noticed another thing I think needs changed, then we can merge.

auto-merge was automatically disabled May 17, 2023 13:31

Head branch was pushed to by a user without write access

@adrinjalali adrinjalali enabled auto-merge (squash) May 17, 2023 13:39
@adrinjalali adrinjalali merged commit 4830416 into scikit-learn:main May 17, 2023
@napetrov napetrov deleted the dev/napetrov_sklernex branch August 31, 2023 10:01
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
@napetrov @thomasjpfan
@ogrisel @REDVM
DOC Update daal4py -> scikit-learn-intelex reference (scikit-learn#26383
5827e2b 
)

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@napetrov @ogrisel @jeremiedbb @adrinjalali @thomasjpfan