[WIP] MAINT Parameters validation for sklearn.neighbors.KNeighborsTransformer #26451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
May 29, 2023
| @@ -342,12 +365,6 @@ class KNeighborsTransformer( | |||
| (178, 178) | |||
| """ | |||
|
|
|||
| _parameter_constraints: dict = { | |||
There was a problem hiding this comment.
for classes, parameter validation for the constructor arguments is done via _parameter_constraints class attribute as you see here, and not via the @validate_params decorator.
And as you can see, it is implemented already for this class, so nothing left to be done for KNeighborsTransformer.
@validate_params is used for functions, and we're adding them to most public functions, for example, this one: #26086. Therefore this PR can be closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#24862
What does this implement/fix? Explain your changes.